Skip to content

ci: check chain versions before tagging - #1500

Open
yyforyongyu wants to merge 3 commits into
btcsuite:sql-walletfrom
yyforyongyu:task-chain-versions
Open

yyforyongyu wants to merge 3 commits into
btcsuite:sql-walletfrom
yyforyongyu:task-chain-versions

Conversation

@yyforyongyu

@yyforyongyu yyforyongyu commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Implement task 451: every push to a release branch runs full normal CI plus five SQLite chain-version checks before tagging. Bitcoin Core versions are discovered automatically from upstream stable releases.

Change Description

  • Cut a candidate branch such as v0.19-branch from maintained sql-wallet after this workflow is present. Pushes to v0.*-branch, including subsequent fixes without a version bump, automatically start Release checks. Ordinary PRs retain normal CI.
  • normal-ci calls the existing CI workflow from the same candidate commit: static/generated checks, lint, unit/race tests, database integration and current-version chain tests. PR commit-range validation retains its existing PR-only guard. Separate concurrency groups prevent the nested CI from cancelling its release caller.
  • fetch-chain-backend-versions discovers the latest stable patch of the three newest Core major lines and their official archive checksums. itest-chain-backend-versions runs the complete SQLite suite for those releases plus btcd v0.27.0/v0.26.2. Core uses the latest selected btcd miner; Neutrino stays current-only in normal CI.
  • The current btcd pin lives only in main.yml; discovery shares it with the current release row and Core miner. Shared installers verify authenticated artifacts/modules and exact running daemon versions. After the full release run passes, a maintainer signs and pushes the tag at that exact tested SHA. These jobs do not create tags or publish release artifacts. Manual selected-ref retries become available once the workflow is also on default master; automatic release-branch pushes only require it on that branch.

Notes

The Core window currently resolves to 32.1, 31.2 and 30.4. The canonical-pin regression reproduces the prior drift and verifies that one main-workflow edit updates ordinary CI, the release row and the Core miner. Workflow/branch/call/concurrency validation, actionlint/ShellCheck, discovery fixtures and live discovery pass. All three signed commits compile independently and stay below 150 weighted additions. The complete representative Core 32.1/SQLite suite passes on maintained tip 1d3cc4d.

Earlier verification covered all ten distinct ordinary/release configurations, including successful full suites for all five selected daemons on a prior base. On base 7a8079e, four lanes passed while btcd v0.26.2 timed out waiting for the miner reorg in both full attempts. Those failures and earlier passing repeats remain recorded; this pin correction changes no daemon, harness or scenario and adds no skip or CI retry. A failing compatibility lane continues to block release success.

Comment thread .github/workflows/main.yml Resolved
Comment thread .github/workflows/main.yml Resolved
Comment thread .github/workflows/main.yml Resolved
@yyforyongyu yyforyongyu added the eng-brain:btcwallet-sql-phase2 eng-brain cycle 2026-07 commitment: btcwallet-sql-phase2 label Nov 12, 2026
@yyforyongyu
yyforyongyu force-pushed the task-chain-versions branch 2 times, most recently from ffed234 to 006da95 Compare November 12, 2026 11:28
Comment thread .github/workflows/main.yml Resolved
Comment thread .github/workflows/main.yml Resolved
@yyforyongyu
yyforyongyu force-pushed the task-chain-versions branch 2 times, most recently from 2837619 to d67bc9e Compare November 12, 2026 13:49
@yyforyongyu yyforyongyu changed the title ci: test chain versions on release tags ci: check chain versions before tagging Nov 12, 2026
@saubyk saubyk added this to lnd v0.22 Nov 12, 2026
@github-project-automation github-project-automation Bot moved this to Backlog in lnd v0.22 Nov 12, 2026
@yyforyongyu
yyforyongyu marked this pull request as ready for review November 14, 2026 21:20
Keep ordinary integration checks on current authenticated daemon
releases. Share Core archive and btcd exact-tag installers across
workflow calls, and reject checksum or installed-version mismatches
before tests start.

Keep compiler selection local to btcd installation so wallet tests use
the configured Go version.
Select the latest stable patch from the three newest Core major lines
using upstream release metadata and official archive checksums.

Read the current btcd pin from ordinary CI and combine it with the
selected previous release. Publish one complete matrix and its current
miner tag only after all discovery succeeds.
Run full normal CI plus five complete SQLite compatibility lanes on
every release branch push before maintainers publish signed tags. Reuse
the normal workflow at the candidate commit and isolate its concurrency
group from the release caller.

Resolve the latest three stable Core major lines and retain the selected
previous btcd release. Share the canonical current pin from normal CI
with the release rows and Core miner. Document tagging the exact passing
candidate SHA.
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 43645782616

Warning

No base build found for commit 1d3cc4d on sql-wallet.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 62.224%

Details

  • Patch coverage: No coverable lines changed in this PR.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 68629
Covered Lines: 42704
Line Coverage: 62.22%
Coverage Strength: 8813.33 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

eng-brain:btcwallet-sql-phase2 eng-brain cycle 2026-07 commitment: btcwallet-sql-phase2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants